Closed hyanwong closed 6 months ago
The update involves refining the GeneticInheritanceGraphLibrary
, focusing on improving data validation and integrity. Changes include refactoring, introducing new constants, updating class attributes and method signatures, and enhancing validation in tables.py
. Corresponding updates in test_tables.py
adjust for these enhancements, adding a new test class to ensure robust validation. This overhaul aims at making the library more reliable and efficient in handling genetic inheritance graphs.
Files | Change Summary |
---|---|
.../tables.py , tests/test_tables.py |
Refactored imports, new constants, updated attributes and method signatures, enhanced validation and data handling; Updated imports, replaced references, modified method parameters, added TestIedgesValidation class |
🐇✨
Changes abound, both big and small,
In the library's halls, we refine it all.
With constants new and validations tight,
Our data's integrity now shines bright.
Let's hop with joy, for together we strive,
To make our genetic graphs come alive.
🌟🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I have tested and profiled the simulations, and this doesn't add to the time (and the skip_validate flag does trim the time slightly). Probably more tests of the flags are needed, but I'm going to merge this as I think it's the right way forward, and is largely tested now (a few more tests wouldn't go amiss, though, as the validation logic is complicated)
And try to get chromosomes working.
This is a pretty big reworking of some of the code, so it would be good to go over it. There are a lot of tests that will need to be added, I suspect. It should, however, allow us to efficiently get the lengths of chromosomes out of the tables (see #27 )
Summary by CodeRabbit