Closed hyanwong closed 11 months ago
The GeneticInheritanceGraph module underwent a refactor, aligning with updates from the tskit
library. Key components like TableGroup
and IntervalTable
were renamed to Tables
and IEdgeTable
, respectively. Data types for table columns shifted from float
to int
, and the handling of tree sequences and sample nodes was updated. This overhaul likely enhances performance and compatibility with tskit
.
File Path | Change Summary |
---|---|
GeneticInheritanceGraph/__init__.py , GeneticInheritanceGraph/constants.py |
Updated imports and constants to align with tskit . |
GeneticInheritanceGraph/tables.py |
Renamed classes, changed column data types, and added methods for handling integer positions and samples. |
tests/conftest.py , tests/gigutil.py , tests/test_tables.py |
Reflected renaming of classes and methods, updated variable names and method calls to match the new structure. |
🐇✨ In the graph where genes intertwine, A change was made, oh so fine. Floats to ints, names anew, CodeRabbit hopped, and the module flew. 🌟🧬
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?
Attention: 14 lines
in your changes are missing coverage. Please review.
Comparison is base (
a7f1a14
) 94.24% compared to head (c67a70a
) 89.30%.
Files | Patch % | Lines |
---|---|---|
GeneticInheritanceGraph/tables.py | 80.00% | 1 Missing and 13 partials :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I also renamed "all_mutation_types_gig" to "all_sv_types_gig": I hope that makes sense @duncanMR (these aren't what we normally call mutations as present in the "mutations" table)
That's a good point re: mutations. Thanks for the changes!
OK, merging. Fixes #43
and rename "TableGroup" to "Tables". We can refer to the tree sequence tables as
ts_tables
when used in a variable.Summary by CodeRabbit
New Features
tskit
for enhanced genetic inheritance data handling.Bug Fixes
Refactor
Tests