hyanwong / giglib

MIT License
4 stars 2 forks source link

Change to integer intervals, Use "IEdge" rather than "Edge" #43

Closed hyanwong closed 11 months ago

hyanwong commented 11 months ago

and rename "TableGroup" to "Tables". We can refer to the tree sequence tables as ts_tables when used in a variable.

Summary by CodeRabbit

coderabbitai[bot] commented 11 months ago

Walkthrough

The GeneticInheritanceGraph module underwent a refactor, aligning with updates from the tskit library. Key components like TableGroup and IntervalTable were renamed to Tables and IEdgeTable, respectively. Data types for table columns shifted from float to int, and the handling of tree sequences and sample nodes was updated. This overhaul likely enhances performance and compatibility with tskit.

Changes

File Path Change Summary
GeneticInheritanceGraph/__init__.py, GeneticInheritanceGraph/constants.py Updated imports and constants to align with tskit.
GeneticInheritanceGraph/tables.py Renamed classes, changed column data types, and added methods for handling integer positions and samples.
tests/conftest.py, tests/gigutil.py, tests/test_tables.py Reflected renaming of classes and methods, updated variable names and method calls to match the new structure.

Poem

🐇✨ In the graph where genes intertwine, A change was made, oh so fine. Floats to ints, names anew, CodeRabbit hopped, and the module flew. 🌟🧬

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can reply to a review comment made by CodeRabbit. - You can tag CodeRabbit on specific lines of code or files in the PR by tagging `@coderabbitai` in a comment. - You can tag `@coderabbitai` in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
codecov-commenter commented 11 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (a7f1a14) 94.24% compared to head (c67a70a) 89.30%.

Files Patch % Lines
GeneticInheritanceGraph/tables.py 80.00% 1 Missing and 13 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== - Coverage 94.24% 89.30% -4.94% ========================================== Files 3 4 +1 Lines 139 187 +48 Branches 22 35 +13 ========================================== + Hits 131 167 +36 - Misses 4 5 +1 - Partials 4 15 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hyanwong commented 11 months ago

I also renamed "all_mutation_types_gig" to "all_sv_types_gig": I hope that makes sense @duncanMR (these aren't what we normally call mutations as present in the "mutations" table)

duncanMR commented 11 months ago

That's a good point re: mutations. Thanks for the changes!

hyanwong commented 11 months ago

OK, merging. Fixes #43