hyanwong / giglib

MIT License
4 stars 2 forks source link

Change name to GeneticInheritanceGraphLibrary #50

Closed hyanwong closed 9 months ago

hyanwong commented 9 months ago

And better coord checking of nonintegers

Summary by CodeRabbit

coderabbitai[bot] commented 9 months ago

Walkthrough

The GeneticInheritanceGraphLibrary has undergone a significant refactor, including class renamings and inheritance structure changes to improve functionality and compatibility with tskit. A to_dict method has been added for object-to-dictionary conversions, and the test suite has been updated to reflect the renaming of the main module and to include new test cases for enhanced robustness.

Changes

File Path Change Summary
.../tables.py - Renamed IEdgeTableRow to TableRow and added a new inheriting IEdgeTableRow class.
- NodeTableRow now inherits from TableRow.
- Added to_dict method in BaseTable.
- Updated add_row and append methods for integer conversion and tskit compatibility.
tests/conftest.py
tests/gigutil.py
tests/test_graph.py
tests/test_util.py
Renamed imported module from GeneticInheritanceGraph to GeneticInheritanceGraphLibrary.
tests/test_tables.py - Updated module import renaming.
- Refactored assertions in test cases.
- Added test_append_bad_coord_type test case.

🐇✨ To code anew, we hop and leap,
With classes renamed, inheritance steep.
Tests now align with library's grace,
In genetic graphs, we find our place.
🧬📊

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can reply to a review comment made by CodeRabbit. - You can tag CodeRabbit on specific lines of code or files in the PR by tagging `@coderabbitai` in a comment. - You can tag `@coderabbitai` in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`