search

hyanwong / giglib

MIT License
4 stars 2 forks source link

Table version of find mrcas #90

Closed hyanwong closed 8 months ago

hyanwong commented 8 months ago

Major reworking of validation so that we can use find_MRCA on a set of tables without converting them to a GIG.

Should fix #69 and also speed up simulations because of #86 (reduce use of as_dict)

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The recent updates to the GeneticInheritanceGraphLibrary introduce a comprehensive suite of enhancements aimed at improving genetic inheritance simulations. Key improvements include the validation of edge inputs, the ability to detect inversions, and enhanced interval handling. These changes are geared towards ensuring more accurate and efficient forward simulations by allowing direct operations on unfrozen tables and incorporating rigorous validation to maintain data integrity.

Changes

Files Change Summary
GeneticInheritanceGraphLibrary/tables.py, tests/test_tables.py Added new imports (collections, logging, portion, sortedcontainers), introduced new constants, methods for edge intervals, table operations, inversion detection, interval properties, copying, bitflag handling, row addition with validation, and MRCA region identification. Added test methods for various scenarios.
tests/gigutil.py Modified __init__ method to take a use_validation parameter, added add_iedge_params method, updated add_inheritance_paths method, updated run method behavior, and modified find_comparable_points method to operate on tables.
tests/conftest.py Renamed the fixture all_sv_types_gig to all_sv_types_no_re_gig, added a new fixture all_sv_types_re_gig, and made changes to node data and edge definitions in fixtures to reflect different genetic inheritance scenarios.

Assessment against linked issues

Objective Addressed Explanation
Validate edges on add_row (#69) ✅

Poem

In the library where genes intertwine,
A rabbit hopped in, with code so fine.
"Let's validate," it said with a cheer,
Edges and nodes, far and near.
🐇 With each leap, a bug it did fix,
Ensuring the genetics, a perfect mix.
In the world of code, it left its mark,
A tiny, wise, coding spark. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
hyanwong commented 8 months ago

@duncanMR - would you like to test whether the forward simulations in test_gigutil.py are faster with this PR? There are some perf stats in https://github.com/hyanwong/GeneticInheritanceGraphLibrary/issues/86. I guess you can run the cProfiler as described in https://github.com/hyanwong/GeneticInheritanceGraphLibrary/issues/86#issuecomment-1970029273 with the old (as of aeb87eb7a416074cd7bafff1d35d94049fcbbd43) and the new code?

hyanwong commented 8 months ago

Merging this now, as it contains a lot of useful stuff. We can revise the API later if need be