hyattpd / Prodigal

Prodigal Gene Prediction Software
GNU General Public License v3.0
445 stars 85 forks source link

Warning when compiling on Linux #39

Closed nigiord closed 5 years ago

nigiord commented 6 years ago

I get the following message when compiling from the git repo on Debian 9 (Stretch).

$ gcc --version
gcc (Debian 6.3.0-18) 6.3.0 20170516
$ make install
gcc -pedantic -Wall -O3 -c -o bitmap.o bitmap.c
gcc -pedantic -Wall -O3 -c -o dprog.o dprog.c
gcc -pedantic -Wall -O3 -c -o gene.o gene.c
gcc -pedantic -Wall -O3 -c -o main.o main.c
gcc -pedantic -Wall -O3 -c -o metagenomic.o metagenomic.c
gcc -pedantic -Wall -O3 -c -o node.o node.c
gcc -pedantic -Wall -O3 -c -o sequence.o sequence.c
sequence.c: In function ‘shine_dalgarno_mm’:
sequence.c:766:27: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
         if(match[k] < 0.0 && (k <= j+1 || k >= j+i-2)) cur_ctr -= 10.0;
            ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -pedantic -Wall -O3 -c -o training.o training.c

gcc -pedantic -Wall -O3 -o prodigal bitmap.o dprog.o gene.o main.o metagenomic.o node.o sequence.o training.o -lm 
install -d -m 0755 /usr/local/bin

Everything seems to work afterwards, but I thought you might want to check that.

Cheers, Nils

tseemann commented 6 years ago

I think that warning is safe to ignore as j and k won't be reaching high values.

hyattpd commented 5 years ago

Yeah, it's nothing to worry about.