hybridbrizz / inventorytotal

Shows the total GE value of all items in your inventory.
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Further customization for GP Value #14

Closed Varietyz closed 2 weeks ago

Varietyz commented 2 weeks ago

Tool Tip: Profit/Loss Enabled image image Tool Tip: Profit/Loss Disabled image

Overlay: Profit/Loss Enabled image image

Overlay: Profit/Loss Disabled image

Default Settings image

ICON Updated to match default icon

hybridbrizz commented 2 weeks ago

Two options:

1.) Continue contributing this project and remove the added licenses. You can add your name to LICENSE only after you have contributed to at least 30% of the plugin's source code. I may be slow to follow up on pull requests and will need to verify myself that it meets a good standard for quality which may take a while. 2.) You have my permission (I granted someone else this last year) to branch this project into your own separate plugin and publish it under a different name. Honestly I'd recommend this option because seem to have a lot of good ideas and having your own plugin forked from this will give you creative control over it.

hybridbrizz commented 2 weeks ago

Actually I'm just going to pull the plug on us working together. Feel free to fork and extend into your own separate plugin (obviously because of the bsd license) but I'm closing this PR and reverting your one from earlier and will be ignoring all further PRs you make.

Varietyz commented 2 weeks ago

Actually I'm just going to pull the plug on us working together. Feel free to fork and extend into your own separate plugin (obviously because of the bsd license) but I'm closing this PR and reverting your one from earlier and will be ignoring all further PRs you make.

My sincere apologies. I thought i had to add the licenses, i was not correctly informed on how they work exactly. i'm quiet new to contributions and am still in the learning process..

I do not wish to claim any of your work as my own, if this was the impression you received of this.

Its an honest mistake for which i hope you can forgive me.

I respect your decision and wish you best of luck.

Again, i apologize for the mistake. i will make sure i do not make a similar mistake again.

I do want to Thank you for pointing out that a contribution of atleast 30% is needed to the overall source code before a certain action can be made.

I was of the impression, when one had worked on a file, they needed to add the licensing.

Honestly feel pretty beat up by my mistake and i hope i did not cause you too much trouble.