hybridgroup / cylon-firmata

Cylon adaptor for the Firmata protocol
http://cylonjs.com
Other
45 stars 10 forks source link

How should I handle an inverted servo? #39

Closed daniellmb closed 9 years ago

daniellmb commented 9 years ago

I realize I can just minus the value from 180 but I'm curious if there is an equivalent to isInverted in johnny-five.

https://github.com/rwaldron/johnny-five/wiki/Servo

deadprogram commented 9 years ago

Hi, @daniellmb there is not currently, but seems pretty easy to add such a feature. This should be added to https://github.com/hybridgroup/cylon-gpio/issues and we'd love to see a PR, of course!

deadprogram commented 9 years ago

Hi, @daniellmb did you see my comment that this is more properly a feature request on cylon-gpio? That is where the servo code is https://github.com/hybridgroup/cylon-gpio/blob/master/lib/servo.js

I'm going to close this issue, if you like please open a new issue on this topic under cylon-gpio.

Thanks!

daniellmb commented 9 years ago

yep I did, thanks