hybridgroup / cylon-gpio

Cylon drivers for GPIO devices
http://cylonjs.com
Other
19 stars 14 forks source link

Changed continuous-servo ccw value to 0 #48

Closed ericterpstra closed 9 years ago

ericterpstra commented 9 years ago

A value of 89 is not far enough from the rest point to move the servo. Because 180 is the extreme value for the clockwise rotation, I think it makes sense to set counterclockwise to the opposite extreme - this provides uniform rotation in either direction.

This addresses issue #33

edgarsilva commented 9 years ago

Looks good, but some tests are failing, can you pls update, if not I'll do it later today and merge.

@ericterpstra thanks for the fix :+1: :exclamation:

ericterpstra commented 9 years ago

Sorry about that, I'm pretty new at this. I can fix it later this evening 😬

deadprogram commented 9 years ago

Looks good! Merging...