hybridgroup / cylon-intel-iot

Cylon adaptors for the Intel Edison & Galileo
http://cylonjs.com
Other
35 stars 9 forks source link

Fix writing to servos #13

Closed kevin-brown closed 9 years ago

kevin-brown commented 9 years ago

This fixes an issue with the equation used to calculate the pulse width, where the full number of degrees was being used instead of a percentage.

kevin-brown commented 9 years ago

Closing this off as this is actually handled by cylon-gpio correctly, we just didn't understand what value was supposed to be.

Side note: There don't appear to be any tests for servos, and this PR was green at one point.