search

hybridgroup / cylon-tessel

Cylon adaptor for the Tessel
http://cylonjs.com
Other
13 stars 3 forks source link

427 add coverage report #6

Closed rafmagana closed 10 years ago

edgarsilva commented 10 years ago

@rafmagana is this ok to merge? why is travis failing?

deadprogram commented 10 years ago

Status on the fails on this one?

rafmagana commented 10 years ago

@deadprogram: @stewart, @edgarsilva and I were talking about it, basically there are two options:

  1. Remove travis integration so that the cover task is not executed, but keep the task so that we could execute it locally.
  2. Just close this PR without merging it

@stewart says we can't actually test Tessel code because we need the Tessel itself, but there are some tests already and they run and we could add more tests not specific to the board, so I'd go with number 1.

The problem is that that we can't access process.binding in Travis, and there's a module trying to use it:

audio-vs1053b/index.js:13
var hw = process.binding('hw');

So can't do too much at the moment but removing the integration or do some research about how to fix that.

deadprogram commented 10 years ago

I'm going to merge this in, so it can be run locally by devs. The build is already broken for the reasons already discussed.