lint: fix issues of errorlint, forcetypeassert... - Githubissues

hybridgroup / gobot

Golang framework for robotics, drones, and the Internet of Things (IoT)

https://gobot.io

Other

8.81k stars 1.04k forks source link

lint: fix issues of errorlint, forcetypeassert... #1037

Closed gen2thomas closed 7 months ago

gen2thomas commented 7 months ago

Solved issues and/or description of the change

introducing new linters and fix issues, see also #1031 :

[x] errorlint
[x] forcetypeassert
[x] nakedret
[x] nonamedreturns
[x] bodyclose
[x] containedctx
[x] dogsled
[x] errchkjson
[x] gci
[x] gocritic
[x] noctx
[x] predeclared
[x] thelper
[x] usestdlibvars

additionally fixes:

AnalogRead() in spi/mcp3x0x drivers

Manual test

OS and Version (Win/Mac/Linux): Linux
Adaptor(s) and/or driver(s): Tinkerboard, pwm output, ADS1115, AnalogSensor, TemperaturSensor

Checklist

[x] The PR's target branch is 'hybridgroup:dev'
[x] New and existing unit tests pass locally with my changes (e.g. by run make test)
[x] No linter errors exist locally (e.g. by run make fmt_check)
[x] I have performed a self-review of my own code