neurosky: use serialport adaptor and move driver to drivers/serial - Githubissues

hybridgroup / gobot

Golang framework for robotics, drones, and the Internet of Things (IoT)

https://gobot.io

Other

8.97k stars 1.04k forks source link

neurosky: use serialport adaptor and move driver to drivers/serial #1061

Closed gen2thomas closed 9 months ago

gen2thomas commented 9 months ago

Solved issues and/or description of the change

Move Neurosky MindWave driver to the drivers/serial folder, remove the adaptor and use the serialport adaptor instead.

Additionally:

introduce WithName() and WithBaudRate() for serialport adaptor
increase test coverage

Manual test

none

Checklist

[x] The PR's target branch is 'hybridgroup:dev'
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes (e.g. by run make test_race)
[x] No linter errors exist locally (e.g. by run make fmt_check)
[x] I have performed a self-review of my own code

If this is a new driver or adaptor:

[x] I have added the name to the corresponding README.md
[x] I have added an example to see how to setup and use it
[x] I have checked or build at least my new example (e.g. by run make examples_check)