hybridgroup / gobot

Golang framework for robotics, drones, and the Internet of Things (IoT)
https://gobot.io
Other
8.98k stars 1.04k forks source link

[WIP] add support for VEML7700 (closes #726) #1090

Closed szampardi closed 2 weeks ago

szampardi commented 1 month ago

Solved issues and/or description of the change

726

...

Manual test

Checklist

If this is a new driver or adaptor:

If this is a PR for release:

szampardi commented 3 weeks ago

@gen2thomas saw that.. luckily I happen to be on semi-vacation so will check the errors out tomorrow morning :D

gen2thomas commented 3 weeks ago

@szampardi no worry - after some month of nearly do nothing for gobot I determine also problems with CircleCI, at least on the UI. Hopefully I can solve this or it does not happen on server.

gen2thomas commented 3 weeks ago

Hi @szampardi , please rebase to dev branch - the CI checks are working.

Thanks Thomas

szampardi commented 3 weeks ago

please rebase to dev branch

well that didn't go as expected :D

gen2thomas commented 3 weeks ago

From the commit history I think it was a merge not a rebase. After an rebase your commit should be the last (newest) in the history.

gen2thomas commented 2 weeks ago

superseded by #1099