search

hybridgroup / gocv

Go package for computer vision using OpenCV 4 and beyond. Includes support for DNN, CUDA, and OpenCV Contrib.
https://gocv.io
Other
6.62k stars 863 forks source link

Add float version of BoxPoints and MinAreaRect #1164

Closed TeCHiScy closed 6 months ago

TeCHiScy commented 6 months ago

This PR add float version of BoxPoints and MinAreaRect, named BoxPoints2f and MinAreaRect2f, respectively. Structs including RotatedRect2f and Size2f are also added to support this feature.

close #1152

TeCHiScy commented 6 months ago

Hi @deadprogram, the PR is finished, please review, thanks.

deadprogram commented 6 months ago

Hello @TeCHiScy thank you for the PR.

Could you please rebase against the latest dev branch? It should then be able to pass all of the tests without a problem, from how it looks.

Thanks!

TeCHiScy commented 6 months ago

Hello @TeCHiScy thank you for the PR.

Could you please rebase against the latest dev branch? It should then be able to pass all of the tests without a problem, from how it looks.

Thanks!

Done, all checks passed now. @deadprogram

deadprogram commented 6 months ago

Great thank you @TeCHiScy for the quick response. Now merging.