hybridgroup / kidsruby

KidsRuby is a Ruby programming environment meant for kids to learn and have fun!
http://kidsruby.com
Other
335 stars 104 forks source link

fix bug in save dialog #105

Open eaglestone opened 11 years ago

eaglestone commented 11 years ago

Save dialogue changed to default to home directory and ensures .rb extension added

rafmagana commented 11 years ago

Thanks for your PR, but this is what I get with your code: http://d.pr/i/2IWX, in your local you see ".rb"? which OS are you using? I changed your code to be:

fileName = Qt::FileDialog.getSaveFileName(self, tr("Save Ruby Code"), "#{Dir.home}/.rb")

and I get this: http://d.pr/i/tzN3, which is what your trying to accomplish, I think.

I'm on a Mac, with 10.8.2.

We appreciate.

eaglestone commented 11 years ago

Hi and thanks for getting back.

I'm on Windows (7 and 8) and I get the opposit result to you on the mac.

My code gives: http://d.pr/i/Drw5 with the file type set to .rb

and yours gives: http://d.pr/i/S6ZD

I guess QT is implemented differently on each platform?

I'm trying to get KidsRuby to automatically add the .rb extension during save it's a common problem for the kids at my school who often forget.

This is my first ever PR / contribution to an open source project so a big thank you for being gentle with me! :o)

On 1 August 2013 19:15, Rafael Magana notifications@github.com wrote:

Thanks for your PR, but this is what I get with your code: http://d.pr/i/2IWX, in your local you see ".rb"? which OS are you using? I changed your code to be:

fileName = Qt::FileDialog.getSaveFileName(self, tr("Save Ruby Code"), "#{Dir.home}/.rb")

and I get this: http://d.pr/i/tzN3, which is what your trying to accomplish, I think.

I'm on a Mac, with 10.8.2.

We appreciate.

— Reply to this email directly or view it on GitHubhttps://github.com/hybridgroup/kidsruby/pull/105#issuecomment-21958029 .

deadprogram commented 10 years ago

@rafmagana did you retest this since @eaglestone made some additional commits?