search

hybridgroup / mechanoid

Mechanoid is a framework for WebAssembly applications on embedded systems and IoT devices.
https://mechanoid.io
Apache License 2.0
174 stars 8 forks source link

log: correctly separate normal Log() from Debug() logging #19

Closed deadprogram closed 7 months ago

deadprogram commented 7 months ago

This PR improves logging by correctly separating normal mechanoid.Log() which you would expect to always appear from a new mechanoid.Debug() function for logging only when -tags=debug.

orsinium commented 7 months ago

Maybe it's nice to be able to disable both. It's useful to turn off any output when running benchmarks.

deadprogram commented 7 months ago

Good idea, I will do that in a future PR, when I also change the signature to Log(args ...any)

deadprogram commented 7 months ago

Thanks for review and feedback @orsinium now merging.