search

hybridgroup / rubyserial

FFI Ruby library for RS-232 serial port communication
https://rubygems.org/gems/rubyserial
Other
154 stars 27 forks source link

Fixing #14

Closed ttane closed 9 years ago

ttane commented 9 years ago

I was trying to use your project with the EV3 Lego, but after the first command, it stopped answering. I made this minor change and everything started to work ok. It is my first commit on github, I'm sorry if I made something wrong.

deadprogram commented 9 years ago

@hunterboerner can you please look at this?

hunterboerner commented 9 years ago

Will test when I get home. 

— Theron Boerner

On Tue, Nov 4, 2014 at 9:11 AM, Ron Evans notifications@github.com wrote:

@hunterboerner can you please look at this?

Reply to this email directly or view it on GitHub: https://github.com/hybridgroup/rubyserial/pull/14#issuecomment-61653673

hunterboerner commented 9 years ago

@deadprogram no need. It's been in dev branch for a while https://github.com/hybridgroup/rubyserial/commit/d6329dbe37780624a7a5b7ee8f7064de429510d1.

hunterboerner commented 9 years ago

I guess cut a release and then close this?

deadprogram commented 9 years ago

Sounds like it, yes. Also, we should stop using dev branch, and stick to master + feature branches.

hunterboerner commented 9 years ago

Ok. me thinks it is best if you cut the release

ttane commented 9 years ago

Thank you!