search

hybridgroup / rubyserial

FFI Ruby library for RS-232 serial port communication
https://rubygems.org/gems/rubyserial
Other
154 stars 27 forks source link

Exception Overkill #31

Closed kaiserprogrammer closed 6 years ago

kaiserprogrammer commented 8 years ago

Why does RubySerial::Exception inherit from Exception instead of StandardError?

I thought Exception class should be used when further program execution is discouraged or impossible but I get this kind of exception-level for file not found.

deadprogram commented 8 years ago

Hi, @kaiserprogrammer seems to me like you have the right idea. Care to submit a PR with that? :)

missbach commented 7 years ago

Hi @deadprogram, I just submitted PR for this. Can you please take a look? :)