search

hybridgroup / rubyserial

FFI Ruby library for RS-232 serial port communication
https://rubygems.org/gems/rubyserial
Other
154 stars 27 forks source link

Wrong NCCS in linux_constants.rb #46

Closed david942j closed 6 years ago

david942j commented 6 years ago

https://github.com/hybridgroup/rubyserial/blob/adeb47432e0dfa284e20707bb379daf6c4daf8ae/lib/rubyserial/linux_constants.rb#L23

I checked the latest glibc source and the value should be 32. ref: glibc online source

This will effect the offset of c_ispeed, c_ospeed in struct Termios

hunterboerner commented 6 years ago

@deadprogram

deadprogram commented 6 years ago

Thank you for looking into this, if you could please create a PR to address this it would be ideal, since your understanding is so complete @david942j

david942j commented 6 years ago

OK I'll do it

david942j commented 6 years ago

@deadprogram I've opened a pr :)