Closed Qsppl closed 6 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Probably need to add
.test.ts
to .npmignore
Thanks for the PR. I'll look at the changes on my local machine soon.
Tests should be placed in /test/typescript/...
- the repo structure separates them from the source. And /test/
is already ignored. Also, I think it would be great to add a Typescript compiler as a dev dependency and add an npm script to run tests on those files.
I'll do it today.
Notice that I replaced the "module declaration" in the types\index.d.ts file
to a valid module for compatibility with ESM modules both within the package and for users of the package.
This shouldn't cause any problems, but just in case, check if the behavior has changed in project builders like "Vite".
I made several formatting errors in previous commits. In the Last Three Commits, I explicitly declared the project's formatting settings in the project so that other developers could immediately write code without having to configure their IDE. I also added recommendations for installing extensions for VSCode for technologies that it does not support natively.
I did everything? Can you accept PR?
I'll review it today :)
Generally, it looks fine. I am not yet convinced about adding some meta configuration for the editor things (but recently I listened to the talk that recommended it). As a weekend is ahead, I'll be back next week :) I hope that it's not a problem.
Have a nice weekend)
Hello, if in order to accept PR you need to do additional work or explain in more detail some changes in PR - write, I will do this work.
I don't know what the mistake is.
Safari 17.0 (Linux x86_64) router: test app connected navigate by pushing and pulling views from the stack FAILED
RangeError: Maximum call stack size exceeded. thrown
RangeError: Maximum call stack size exceeded. thrown
RangeError: Maximum call stack size exceeded. thrown
RangeError: Maximum call stack size exceeded. thrown
RangeError: Maximum call stack size exceeded. thrown
This is it?
Sorry, my fault. I forgot to add one missing fix with the latest commits. Pull main
, it should be fine now.
There was a bug there. Please rebase last time, and it will be ready to be merged.
All is ready?
Yes, thanks for your contribution 🎉
A more detailed description is in the commits themselves, but not in the PR.