codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
b16416b) to head (6e16df9).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## normalize-the-asset-api #1910 +/- ## =========================================================== Coverage 100.00% 100.00% + Complexity 1876 1875 -1 =========================================================== Files 192 192 Lines 4954 4951 -3 =========================================================== - Hits 4954 4951 -3 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR simplifies the AssetService API by making the
HYDEFRONT_VERSIONandHYDEFRONT_CDN_URLconstants protected instead of public, as these no longer have any influence outside of the class, after https://github.com/hydephp/develop/pull/1910. This change improves encapsulation and reduces the public API surface, but it is a breaking change for any code directly accessing these constants. The PR also removes related unit tests that are no longer applicable due to the change in visibility.