hydephp / develop

The HydePHP Source Code Monorepo
https://hydephp.com
MIT License
13 stars 6 forks source link

[2.x] Remove the `preferQualifiedUrl` parameter from the asset helper #1913

Closed caendesilva closed 2 months ago

caendesilva commented 2 months ago

This is part of https://github.com/hydephp/develop/pull/1904 and removes the second parameter of the asset helper to automatically assume the user wants a qualified url when a base url is set. Additionally, it makes little sense to set such a configuration at the method level. It also matches Laravel more https://laravel.com/docs/11.x/helpers#method-asset

See https://github.com/hydephp/develop/discussions/1916

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a800618) to head (cd9d67f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## normalize-the-asset-api #1913 +/- ## =========================================================== Coverage 100.00% 100.00% + Complexity 1871 1870 -1 =========================================================== Files 192 192 Lines 4940 4940 =========================================================== Hits 4940 4940 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.