search

hydephp / develop

The HydePHP Source Code Monorepo
https://hydephp.com
MIT License
13 stars 6 forks source link

[2.x] Normalize asset cache busting #1915

Closed caendesilva closed 2 months ago

caendesilva commented 2 months ago

This PR is part of https://github.com/hydephp/develop/pull/1904 and fixes a major discrepancy where Asset::mediaLink() adds a cache busting key but Hyde::mediaLink() does not. Now, all asset helpers will use cache busting when enabled.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (82c7600) to head (d8cb4e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## normalize-the-asset-api #1915 +/- ## =========================================================== Coverage 100.00% 100.00% - Complexity 1871 1873 +2 =========================================================== Files 192 192 Lines 4942 4944 +2 =========================================================== + Hits 4942 4944 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.