search

hydephp / publications

Upcoming Publications Feature - HydePHP Extension
MIT License
0 stars 0 forks source link

Collect extra data like validation rules when creating a new publication type field definition #5

Closed caendesilva closed 1 year ago

caendesilva commented 1 year ago

Here we could collect other data like the "rules" array for the field. MakePublicationTypeCommand.php#L104

github com_hydephp_develop_pull_685

caendesilva commented 1 year ago

@rgasch What do you think about this? Is custom validation rules common enough to bother the user by asking for them on each field generation?

rgasch commented 1 year ago

IMHO, this would be almost never used ... I could be wrong however

caendesilva commented 1 year ago

IMHO, this would be almost never used ... I could be wrong however

Agreed. Will remove the todo marker next time I'm on the branch. Thanks for the input!

caendesilva commented 1 year ago

Closing as wontfix in https://github.com/hydephp/develop/commit/2dc0d9aea33ab2b1c8b83e45ce6f05aafa0a0b19