Events are broken since choo implementation

hydra-synth / hydra

Livecoding networked visuals in the browser

https://hydra.ojack.xyz

GNU Affero General Public License v3.0

2.15k stars 261 forks source link

Events are broken since choo implementation #185

Closed geikha closed 2 years ago

geikha commented 2 years ago

Example from pressing Ctrl+Shift+S

17:24:17 🚨 choo No listeners for screencap
bundle.min.js?1.3.0:161 17:24:17 ✨ choo screencap 0ms

Same happens with Ctrl+Shift+L, for example

Issue also reported by obakegaku on the discord

ojack commented 2 years ago

Are these the only two commands that are not working?

geikha commented 2 years ago

Just checked all of them, that seems to be the case. btw while you're at it we could differentiate save screenshot and save .js file as we'd talked ? iirc we talked about keeping Ctrl+Shift+S as save screenshot and doing Ctrl+Alt+Shift+S for the .js file.

ojack commented 2 years ago

fixed in v1.3.3