search

hydra-synth / hydra

Livecoding networked visuals in the browser
https://hydra.ojack.xyz
GNU Affero General Public License v3.0
2.15k stars 261 forks source link

Remote streams not working #186

Closed HelloRibs closed 2 years ago

HelloRibs commented 2 years ago

pb.list() returns a ['[object Object]']

geikha commented 2 years ago

Further investigation: Setting a two way stream (with custom names set to each peer). The source doesn't load anything. Matter of fact. s0.src returns null. Running s0.initStream('name') logs:

Already connected to.. undefined

Seems Hydra can't find any other instances of Hydra running on the same server.

HelloRibs commented 2 years ago

Hi! I'm looking at the streaming issue and found some potential errors:

I was wondering if this issue could come from the socket.io and socket.io-client package versions. I'm just getting familiar with the code and hoping this information to be helpful 🌹

ojack commented 2 years ago

Yes! It seems that it is never establishing a connection to the server. Good idea to check socket.io

On Fri, Apr 8, 2022, 18:07 Ribs @.***> wrote:

Hi! I'm looking at the streaming issue and found some potential errors:

  • The user nick is never saved in the id/nicks object, or at least I didn't find it
  • The Socket instance appears as { connected: false, ... } and it does not look like it's sending anything
  • I hardcoded the id/nicks and it actually showed the console.log("THIS IS THE PEER", peer) and console.log("peer signal sending over sockets", id, signal) apparently with good data, but
  • The streaming never started

I was wondering if this issue could come from the socket.io http://socket.io and socket.io-client package versions. I'm just getting familiar with the code and hoping this information to be helpful 🌹

— Reply to this email directly, view it on GitHub https://github.com/hydra-synth/hydra/issues/186#issuecomment-1093046421, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFOVSKTMKHU3PIZWDPVAQTVEBKUZANCNFSM5RYB4QMA . You are receiving this because you were assigned.Message ID: @.***>

HelloRibs commented 2 years ago

Small update on this: I tried moving to older commits (the oldest was from Feb 2021) but I got the same ['[object Object]'] when pb.list()

ojack commented 2 years ago

@HelloRibs that fixed it! reverted the socket.io versions and now all fixed in v1.3.4 :) :)

milangress commented 1 year ago

@ojack hey it think the patchbay / connection to other streams broke again :( pb.list() returns a ['[object Object]']

do you think it would be possible to take a look again? I would love to use it in a workshop