hydra-synth / hydra

Livecoding networked visuals in the browser
https://hydra.ojack.xyz
GNU Affero General Public License v3.0
2.19k stars 269 forks source link

Hide code via urlParameter doesn't work anymore #294

Open PLNech opened 8 months ago

PLNech commented 8 months ago

Hey amazing hydra team! I used to be able to hide code by default in my created works on hydra.ojack.xyz with &show-code=false. I see that it doesn't work anymdraore in previous links I had shared, and indeed the code for that param seems commented:

https://github.com/hydra-synth/hydra/blob/f2c53a6913d5bafa43cfbd692c98b07263b63303/src/views/editor/editor.js#L72-L79

Do you know why? I'd love to have this feature again - Happy to brush off my web skills and do a little PR for hydra if you think it's welcome :hugs:

ojack commented 8 months ago

it should work with 'showCode=false'!

we should make it work with 'show-code' also

PLNech commented 8 months ago

Ah nice, indeed this works! I'll use this for new creations 🤗

As for supporting the old syntax, good idea it would fix already shared links 😁

Thank you @ojack for the super quick reply 🙏

ojack commented 8 months ago

great! feel free to PR for supporting the old syntax if you would like :)

On Mon, Mar 4, 2024 at 3:29 PM Paul-Louis NECH @.***> wrote:

Ah nice, indeed this works! I'll use this for new creations 🤗

As for supporting the old syntax, good idea it would fix already shared links 😁

Thank you @ojack https://github.com/ojack for the super quick reply 🙏

— Reply to this email directly, view it on GitHub https://github.com/hydra-synth/hydra/issues/294#issuecomment-1976706017, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFOVSONFCPW7GZDRVYTMULYWSALDAVCNFSM6AAAAABEFHTMGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWG4YDMMBRG4 . You are receiving this because you were mentioned.Message ID: @.***>

asorc commented 5 months ago

Sorry... Where do I have to type '&show-code=false'?

Is It possible to do It also on tablets and smartphones?

Thanks in advance...

PLNech commented 4 months ago

@asorc in the URL! for example if you load this work of mine

https://hydra.ojack.xyz/?sketch_id=vK0m5fziaoD5yUfp

You will see the code:

image


While if you load

https://hydra.ojack.xyz/?sketch_id=vK0m5fziaoD5yUfp&showCode=false

You only see the work:

image