search

hydrabus / hydrafw

HydraBus HydraFW official firmware for open source multi-tool for anyone interested in learning/developping/debugging/hacking/Penetration Testing for basic or advanced embedded hardware
https://hydrabus.com/hydrabus-1-0-specifications
Apache License 2.0
362 stars 92 forks source link

src/hydrabus/commands.c: improve help output on some console commands #156

Closed ia closed 8 months ago

ia commented 8 months ago

Hello. Just another tiny help - patch to close the related task.

The local build has been successfully tested. The log from my hydrabus:

> jtag
Device: JTAG1
GPIO resistor: pull-up
Frequency: 2000000Hz
Bit order: LSB first
jtag1> help brute
Bruteforce JTAG pins on x pins starting from PB0
   bypass         Performs a BYPASS scan on x pins (PB0 up to PB11)
   idcode         Performs an IDCODE scan on x pins (PB0 up to PB11)
jtag1> exit
> 2-wire
Device: twowire1
GPIO resistor: floating
Frequency: 1000000Hz
Bit order: MSB first
twowire1> help brute
Perform a SWD enumeration on x pins (PB0 up to PB11)
twowire1> exit
>

Is it ok? Or should the 2-wire help output be in the full accordance with wiki, i.e. "Perform a SWD enumeration on x pins (PB0 up to PB11) with x from 2 to 11"? Let me know.

bvernoux commented 8 months ago

Thanks a lot for an other great contribution It is perfect like that as if we add "with x from 2 to 11" it will be a bit too long at end the purpose was mainly to clarify the brute force is done using PB0 up to PB11 then additional details can be found in Wiki (or even checking source code ...)