search

hydrabus / hydrafw

HydraBus HydraFW official firmware for open source multi-tool for anyone interested in learning/developping/debugging/hacking/Penetration Testing for basic or advanced embedded hardware
https://hydrabus.com/hydrabus-1-0-specifications
Apache License 2.0
365 stars 92 forks source link

Fix integer comparison error by ensuring GITHUB_CI_CD is defined #170

Closed seuros closed 6 months ago

seuros commented 6 months ago

This commit resolves the error encountered when GITHUB_CI_CD is unset or non-integer by defaulting it to 0.

./scripts/env.sh: line 22: [: : integer expression expected
bvernoux commented 6 months ago

Thanks for your contribution but could you tell me in which case/environment there was an error "./scripts/env.sh: line 22: [: : integer expression expected" ? (as the actual script work fine on GitHub CI see latest build https://github.com/hydrabus/hydrafw/actions/runs/8626278775/job/23644227325)

seuros commented 6 months ago

I tried to run it on my own runner machine. GITHUB_CI_CD is not defined as it using https://github.com/nektos/act