hydralauncher / hydra

Hydra is a game launcher with its own embedded bittorrent client
MIT License
10.95k stars 2.63k forks source link

[BUG] Hydra misleads users when it doesn't have write permissions to a folder #1105

Open MigProPlayer opened 5 hours ago

MigProPlayer commented 5 hours ago

Describe the bug

Issue #1059 kind of mentions this, but it doesn't go into detail and give solutions.

When starting a download to a folder which Hydra doesn't have permissions to access, (such as Program Files) instead of throwing an error and telling the user to pick another location, Hydra shows that the download has 0 seeds (and shows the number of peers inaccurately, fluctuating between 4 and 1 and sometimes going up to 7 or 9, when the torrent has in reality 45+ peers) and keeps on increasing the completion time and showing a very small download speed, misleading the user into thinking that the torrent in question has no seeders. (this was why it took me a while to discover why my Hydra was no longer downloading anything as before, Hydra was always launched as admin, so I set the download path to Program Files, which only programs with admin rights can write to)

No permissions image

With permissions image

Steps to Reproduce

  1. Start a new download
  2. Set the download location to a folder which Hydra doesn't have access to (for example Program Files if Hydra isn't running as admin)
  3. Watch above behaviour happen and the download not downloading
  4. Cancel the download
  5. Start another download but this time to a location which Hydra has access to (the user's Downloads folder for example)
  6. Watch the download downloading normally

Expected behavior

When starting a new download, Hydra should check the download location and throw an error if it can't access it.

The error should tell the user to change the download location and try again, or to try running Hydra as an administrator.

Additional information and data

logs.txt - Recreated the bug and the "normal" behaviour, but these logs should probably not be needed anyways.

Operating System

Windows 11 Pro

Hydra Version

3.0.1

Before opening this Issue

zamitto commented 3 hours ago

Thanks for the report. We noticed this while running tests for 3.0. Unfortunately, we couldn't solve it in time.