hydrateio / docz-plugin-storybook

Docz plugin that makes migrating from Storybook a breeze.
76 stars 1 forks source link

removed docz-core as a dependency and made the createPlugin function … #26

Closed jpeters5392 closed 5 years ago

jpeters5392 commented 5 years ago

…a parameter to the storybook plugin

Reasoning for this change.

After integrating the plugin to emcm-ui both Kevin and I ran into errors when importing the plugin to doczrc.js. It was an error importing and not using, and it was an error while calling callee, caller, or arguments while in strict mode. The call stack came from esm.js which is a nested dependency inside of docz-core. The only thing we used docz-core for is to get the createPlugin function, so I removed the dependency and made it so the consumer of the plugin can pass in that function for their docz version. This change resolved the issue.