hydraulic-software / conveyor

Gradle plugin, user guide and discussion forums for Conveyor
https://conveyor.hydraulic.dev
Apache License 2.0
123 stars 9 forks source link

Only the last entry in an Electron ASAR Unpack array is shipped #112

Closed trulysinclair closed 3 months ago

trulysinclair commented 4 months ago

Describe the bug When specifying multiple files or globs to be unpacked, only the last entry of the array is added to the final build. However, in dev such as using "conveyor run" it appears to work as expected.

To Reproduce Steps to reproduce the behavior:

  1. Specify multiple entries to unpack
  2. Package the application "conveyor make app"
  3. Open the output directory under "resources/app.asar.unpacked/"
  4. See only the last entry such as either "node_modules" or "product.json"

Expected behavior All entries should be available under the unpacked directory, in my case, a product.json, pwd.db, Prisma ".node" files, and the Prisma Scheme engine ".exe" file.

Screenshots Here's the last entry commented out which shows the node files: image

Here's the last entry uncommented which shows only the pwd.db file: image

Desktop (please complete the following information):

Additional context

I've also tried turning prune on and off which didn't change anything. It should be noted that individual additions using electron.asar.unpack += "..." does not produce the same output as an explicit array declaration. Instead, only the last array is produced in the JSON output.

image

However, explicit definition does of course work.

electron.asar.unpack = [
    "product.json"
    "**/*.node"
    "**/*.exe"
    "pwd.db"
  ]
mikehearn commented 3 months ago

This should be fixed in 14.3