Setting `app.revision` produces incorrect linux package version

hydraulic-software / conveyor

Gradle plugin, user guide and discussion forums for Conveyor

https://conveyor.hydraulic.dev

Apache License 2.0

123 stars 9 forks source link

Setting `app.revision` produces incorrect linux package version #24

Closed ennerf closed 2 years ago

ennerf commented 2 years ago

Describe the bug Setting app.revision breaks the linux package version

app.version = 1.0
app.revision = 1

mikehearn commented 2 years ago

Thanks for the bug report! A fix will be in the next release. There was an overly tight regex which escaped notice; the test suite has been improved to both verify the version number check against various inputs and also use a revision in the integration tests. I'll close this bug once the release is done.