search

hydrausb3 / hydrausb3_fw

HydraUSB3 (WCH CH569) open source test firmware / examples / libraries to experiment with streaming / high-speed protocols (USB2 HS, USB3 SS, HSPI, SerDes...)
Apache License 2.0
75 stars 12 forks source link

Serial debug not working in blinky example #5

Closed hansfbaier closed 2 years ago

hansfbaier commented 2 years ago

The serial console is not initialized/working in the blinky example. This is very important, because the blinky is the baseline project for most projects one might start. Would be great if it also printed "Blink!" on the serial console.

bvernoux commented 2 years ago

Yes it can be improved like in your proposal Note: I plan a refactor of log_xxx API too see https://github.com/hydrausb3/hydrausb3_fw/issues/4

In future I want to push more towards SerDes for traces which is unique feature to avoid slow UART (and allow real-time non intrusive log/debug traces) So it can be added with UART today(especially in HydraUSB3_Blink_ULED example) and write other examples with traces over USB2, USB3, SerDes or even HSPI see https://github.com/hydrausb3/hydrausb3_fw/issues/8

bvernoux commented 2 years ago

PR is welcome (like that you can do like you wish thanks to keep it simple)

bvernoux commented 2 years ago

Fixed in commit https://github.com/hydrausb3/hydrausb3_fw/commit/efb70146722aece07f14af2266381314ba90f7cc any feedback is welcome