search

hydrian / TTRSS-Auth-LDAP

GitHub repository for Tiny Tiny RSS's auth_ldap plugin
https://github.com/hydrian/TTRSS-Auth-LDAP/wiki
Other
28 stars 21 forks source link

Fix ldaps connect #34

Closed Alexconquer closed 1 year ago

Alexconquer commented 5 years ago

Fix for ldaps error #24

hydrian commented 5 years ago

What version of php did you test your code on?

Alexconquer commented 5 years ago

I use PHP 7.0.33-0+deb9u1

faust64 commented 3 years ago

Using the original plugin, I can see tinytinyrss failing to connect my OpenLDAP, with the following message in slapd logs:

5f943ab4 conn=7283 fd=16 ACCEPT from IP=x.x.x.x:59934 (IP=0.0.0.0:1636)
TLS: can't accept: error:1408F10B:SSL routines:ssl3_get_record:wrong version number.

In tt-rss logs:

IP: X.X.X.X. Request URI: /tt-rss/public.php?return=https%3A%2F%2Ftinytinyrss.x.x.x.com%2Ftt-rss%2FUser agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36 |   | 16:27
-- | -- | --
E_USER_NOTICE (1024) | :0 | Array ( [host] => openldap-kube.ci.svc.cluster.local [basedn] => dc=xxx,dc=com [port] => 1636 [starttls] => )

IP: X.X.X.X Request URI: /tt-rss/public.php?return=https%3A%2F%2Ftinytinyrss.x.x.x.com%2Ftt-rss%2FUser agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36 |   | 16:28
-- | -- | --
E_USER_ERROR (256) | :0 | LDAP bind(): Bind failed ()with DN cn=tinytinyrss,ou=services,dc=xxx,dc=com

I confirm applying that patch fixed it. Thanks @Alexconquer

Using PHP 7.4. How wasn't this merged already?