search

hydro-project / anna

A low-latency, cloud-native KVS
Apache License 2.0
702 stars 106 forks source link

Fixes segfault on client/cpp/cli.cpp and corrects path in scripts/run-tests.sh #48

Closed WildCryptoFox closed 4 years ago

codecov-commenter commented 4 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files          45       45           
  Lines        1745     1745           
=======================================
  Hits         1163     1163           
  Misses        582      582

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf4175b...f7f9856. Read the comment docs.

vsreekanti commented 4 years ago

Thanks, @WildCryptoFox!

WildCryptoFox commented 4 years ago

@vsreekanti I think you merged in the wrong direction. You added a merge commit into this PR but didn't merge this into master. Never seen this one before!

vsreekanti commented 4 years ago

@WildCryptoFox I merged master into this branch because there were new commits on master and the branch had to be updated. I had to wait for Travis to run before merging this back into master but forgot to check up again. Either way, looks like we're all set. Thanks again for your PR!