Closed saurav-c closed 4 years ago
Thanks, @saurav-c! Don't we also need to increase change the limit on the number of pinned functions on the executor side here?
That's also what I thought, and we talked about it earlier. But I tried executing a DAG locally and ran a few of the benchmarks successfully without changing the limit. So I'm not exactly sure if we need that change.
:exclamation: No coverage uploaded for pull request base (
master@bf02804
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #24 +/- ##
========================================
Coverage ? 89.5%
========================================
Files ? 13
Lines ? 896
Branches ? 0
========================================
Hits ? 802
Misses ? 94
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
...oudburst/server/scheduler/policy/default_policy.py | 95.75% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bf02804...f95f287. Read the comment docs.
Hm. @saurav-c, do you mind debugging a little and seeing why that line I linked earlier isn't causing DAG registration to fail? I want to make sure we're not seeing some weird misconfiguration by mistake that'll pop up later.
Solves #23