hydro-project / fluent

A data-driven compute platform
Apache License 2.0
1.22k stars 173 forks source link

Enables g++ compilation #23

Closed vsreekanti closed 6 years ago

vsreekanti commented 6 years ago

Fixes #15, #20.

For some reason, make test fails with a seg fault when compiling with g++, but the KVS processes all still are able to start, and the simple test succeeds. It just a bug with the unit tests.

codecov[bot] commented 6 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files          50       50           
  Lines        1438     1438           
=======================================
  Hits          902      902           
  Misses        536      536
Impacted Files Coverage Δ
kvs/src/hash_ring/hash_ring.cpp 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ff703d...d4b51a4. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@810367a). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   62.72%           
=========================================
  Files             ?       50           
  Lines             ?     1438           
  Branches          ?        0           
=========================================
  Hits              ?      902           
  Misses            ?      536           
  Partials          ?        0
Impacted Files Coverage Δ
kvs/src/hash_ring/hash_ring.cpp 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 810367a...42c334b. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   62.79%   62.79%           
=======================================
  Files          50       50           
  Lines        1454     1454           
=======================================
  Hits          913      913           
  Misses        541      541
Impacted Files Coverage Δ
kvs/src/hash_ring/hash_ring.cpp 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 810367a...42c334b. Read the comment docs.