search

hydro-project / fluent

A data-driven compute platform
Apache License 2.0
1.22k stars 173 forks source link

Fixes bug with attempted stoi conversion on depart message #41

Closed vsreekanti closed 5 years ago

vsreekanti commented 5 years ago

Previously, the routing handler attempted to deserialize the join_count in the membership handler every time a message was received. This crashed on depart messages since those include a join count (which is irrelevant when a node is departing). This fixes that bug.

codecov[bot] commented 5 years ago

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   62.38%   62.38%           
=======================================
  Files          50       50           
  Lines        1462     1462           
=======================================
  Hits          912      912           
  Misses        550      550
Impacted Files Coverage Δ
kvs/src/route/membership_handler.cpp 70.45% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e047a9d...a599269. Read the comment docs.