search

hydro-project / fluent

A data-driven compute platform
Apache License 2.0
1.22k stars 173 forks source link

Causal bugfix #90

Closed cw75 closed 5 years ago

cw75 commented 5 years ago
  1. In some cases, we won't have the request id by the time get_async() finishes due to querying the routing system. Since the request id is not used at all for get request, I made it such that get_async no longer returns the request id.
  2. Fixed a bug in the causal store that mistakenly treats some dependencies as covered.
codecov[bot] commented 5 years ago

Codecov Report

Merging #90 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   71.48%   71.49%   +<.01%     
==========================================
  Files          67       67              
  Lines        2921     2929       +8     
==========================================
+ Hits         2088     2094       +6     
- Misses        833      835       +2
Impacted Files Coverage Δ
include/kvs_async_client.hpp 100% <ø> (ø) :arrow_up:
include/kvs_mock_client.hpp 50% <100%> (-19.24%) :arrow_down:
functions/cache/src/causal_cache_utils.cpp 64.55% <100%> (+1.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f283a...9851d42. Read the comment docs.