hydrocode-de / RUINSapp

https://hydrocode-de.github.io/RUINSapp
MIT License
1 stars 1 forks source link

Climate explorer - bug fixes and story mode draft #64

Closed mmaelicke closed 2 years ago

mmaelicke commented 2 years ago

This PR rebuilt most of climate exporer's internal:

The RCP selector can now show more options than just the RCPs found in the netCDF file, to be used here and in the weather explorer. Additionally, the selector can layout in columns or rows. The climate explorer makes use of both, but we should of course make a decision for either column (first reference station) or row (second reference station) for consistency. Decision is up to you @cojacoo.

The plot warning were also fixed but the plot layout was screwed up. Thus, after this PR is finished, @AlexDo1 can fix the layout again and @mmaelicke will re-implement this plot using plotly, as the user has to be able to hover this plot.

codecov[bot] commented 2 years ago

Codecov Report

Merging #64 (218dab5) into main (06ad9d7) will decrease coverage by 0.52%. The diff coverage is 3.78%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   20.09%   19.57%   -0.53%     
==========================================
  Files          19       20       +1     
  Lines        1612     1660      +48     
==========================================
+ Hits          324      325       +1     
- Misses       1288     1335      +47     
Impacted Files Coverage Δ
ruins/apps/climate.py 0.00% <0.00%> (ø)
ruins/components/model_scale_select.py 0.00% <0.00%> (ø)
ruins/components/data_select.py 11.29% <8.82%> (+0.28%) :arrow_up:
ruins/plotting/weather_data.py 8.00% <33.33%> (-0.11%) :arrow_down:
ruins/core/config.py 78.40% <100.00%> (-0.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06ad9d7...218dab5. Read the comment docs.