search

hydrocode-de / integra-frontend

React frontend for INTEGRA
0 stars 1 forks source link

Shade card #141

Closed mmaelicke closed 1 month ago

mmaelicke commented 1 month ago

closes #131

The shading share can now be viewed from the result card. As pruning is not implemented at all, no pruning share is visualized.

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 925da05):

https://integra-223bf--pr141-shade-card-u7vn6d0h.web.app

(expires Wed, 22 May 2024 17:47:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ccb6d271698eb667c2f8f1dbd17a4a78744476bc

mmaelicke commented 1 month ago

This now also implements tree line area. This is a buffer around the calculated lines of half the (hard-coded) width. Then we calculate the agricultural area from that (reference - union of line areas). This is part of #140, but without the option to change the size of a tree line.

The shading area is then the union of all shades, intersected with the agricultural area. This leads to the correct numbers, where shadedArea is just the area of the agricultural area that has been shaded. Meaning, if a shadow of a tree is entirely on the tree-line, it does not account for shaded area. This happens for small trees in the summer months.

@JesJehle, @noobla11 @karpaddel I would suggest this PR 'finishes' the shading topic with respect to the presentation. Given the time left and the open issues, I would suggest to move to something else, after this one is closed.