search

hydrocode-de / integra-frontend

React frontend for INTEGRA
0 stars 1 forks source link

Distance layer nobutton #145

Closed mmaelicke closed 1 month ago

mmaelicke commented 1 month ago

This is an alternative version of #143

Here, the distance measurements are enabled automatically, when the user drags a tree (distance to closest features) or hovers a tree-line (when at least 2 tree lines are on the map).

My opinion: a) I really like the distance on drag; b) I would prefer a button for the tree-line distances.

@noobla11, @karpaddel have a look at both and let me know what you think

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 0c6529a):

https://integra-223bf--pr145-distance-layer-nobut-uvdl0mlp.web.app

(expires Thu, 30 May 2024 06:36:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ccb6d271698eb667c2f8f1dbd17a4a78744476bc

noobla11 commented 1 month ago

This version is way better, I checked in with Christopher additionally.

Would that be possible? We would like to avoid an additional button.

mmaelicke commented 1 month ago
  • distance on drag is perfect, we would only change the size and maybe colour, the numbers are really tiny

Sure.

  • we would like the total length of the tree line only shown left on the panel with the tree line characteristics, not on the map (it is kind of confusing when there are multiple numbers)

Curently, the length of the full tree-line is not shown on the map. Only the distances to the closest 3 trees which are within 150m are shown, along with the distance to the tree-lines within the same radius. I can decrease the thresholds here, if that is what you are referring to.

noobla11 commented 1 month ago

Curently, the length of the full tree-line is not shown on the map. Only the distances to the closest 3 trees which are within 150m are shown, along with the distance to the tree-lines within the same radius. I can decrease the thresholds here, if that is what you are referring to.

Hmm when I drag three trees on the map and drag them apart then at some point a third distance is shown. maybe that is the distance between the first and the third tree then? Maybe it would be better to show only the distances to 2 trees at a time? Or what is the purpose of having the distance to the closest 3 trees displayed?

mmaelicke commented 1 month ago

Maybe it would be better to shown only the distances to 2 trees at a time? Or what is the purpose of having the distance to the closest 3 trees displayed?

Sure. I had to start somewhere.

JesJehle commented 1 month ago

There are some minor issues, which can be fixed after the presentation. I would suggest this is great for now. Change the color to white would make it a bit more readable.

I would remove "Kartenwerzeuge" for now, if we only have the scroll to functionality. But we would need to fix #146 first.