hydrocode-de / integra-frontend

React frontend for INTEGRA
0 stars 1 forks source link

Small changes (low priority) #154

Open karpaddel opened 1 month ago

karpaddel commented 1 month ago

Here we gathered some small issues, which we would like to change. They do not have high priority (do not need to be implemented before the presentation):

karpaddel commented 3 weeks ago

@mmaelicke @JesJehle

JoshuaBWWD commented 6 days ago
noobla11 commented 5 days ago

@mmaelicke Here are some tasks which are already solved I think? Such as "Tree planning" and "German species name". Maybe you could indaicate the completet tasks for clarity :)

mmaelicke commented 5 days ago

yep, just did that. Actually not sure if I replaced the species name everywhere...

The point about copying a tree-line is not a small change, though, but a major development. While copying is something that I can somehow hack in somehow, the moving part is currently close to impossible. That was one of the things that I pointed out, when moving from tree-lines to individual trees as the base data model. If moving entire tree lines is important, we need yet another extra issue for that and I have to think about a possible implementation. Anyway, both will not happen until 15.7.

mmaelicke commented 5 days ago
  • [ ] Shrub-Icons: these look quite large. Can they be downsized, so the relation to the tree size is more appropriate?

As far as I can tell, the sizes largely match. There are sometimes small inconsistencies, when the zoom is not perfectly aligned. Additionally, there is a minimum size implemented, so that icons are always visible. That can affect shrubs, that are below this minimum size for a couple of years. But unfortunately, there is no way around that. I think the smallest icons should not get any smaller...

noobla11 commented 5 days ago

yep, just did that. Actually not sure if I replaced the species name everywhere...

The point about copying a tree-line is not a small change, though, but a major development. While copying is something that I can somehow hack in somehow, the moving part is currently close to impossible. That was one of the things that I pointed out, when moving from tree-lines to individual trees as the base data model. If moving entire tree lines is important, we need yet another extra issue for that and I have to think about a possible implementation. Anyway, both will not happen until 15.7.

Okay thank you for elaborating again. I will open another issue and we go from there.

noobla11 commented 5 days ago
  • [ ] Shrub-Icons: these look quite large. Can they be downsized, so the relation to the tree size is more appropriate?

As far as I can tell, the sizes largely match. There are sometimes small inconsistencies, when the zoom is not perfectly aligned. Additionally, there is a minimum size implemented, so that icons are always visible. That can affect shrubs, that are below this minimum size for a couple of years. But unfortunately, there is no way around that. I think the smallest icons should not get any smaller...

I think we can ditch this task.