Layout improvements on Shade result Card

hydrocode-de / integra-frontend

React frontend for INTEGRA

0 stars 1 forks source link

Closed mmaelicke closed 1 month ago

mmaelicke commented 1 month ago

closes #153

There are still some layout issues, that I can't figure out how to solve right now. We can either merge anyway, or wait until I find a solution.

[ ] Text alignment is slightly off
[ ] Legend is not horizontal, although it is configured to be (bug in plotly?!)
[ ] Pie labels sometimes vanish (either a smaller pie, no label at all or a wider Card could solve the issue)

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 08ee3e0):

_{(expires Wed, 12 Jun 2024 09:04:09 GMT)}

_{Sign: ccb6d271698eb667c2f8f1dbd17a4a78744476bc}

karpaddel commented 1 month ago

Looks nice!

the pie labels can be removed, that is why we have the pop-ups
one typo in the Pop-up text about "Landw. Fläche": "fie" instead of "die"
legend is horizontal, but not central
we would not make a wider card, but one idea was to replace the pie chart with a donut chart -> this way, the shade category might be more visible even when slim (almost no shade)

mmaelicke commented 1 month ago

should all be addressed now