search

hydrocode-de / integra-frontend

React frontend for INTEGRA
0 stars 1 forks source link

Add phaeno tab #198

Closed mmaelicke closed 1 week ago

mmaelicke commented 2 weeks ago

closes #183

The data is there, the functionality is there, the plot is there.

In combination, the data gets lost or out of context on the way into the plot. I'll go debugging....

github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit e710db4):

https://integra-223bf--pr198-add-phaeno-tab-78l10ahc.web.app

(expires Tue, 02 Jul 2024 14:19:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ccb6d271698eb667c2f8f1dbd17a4a78744476bc

mmaelicke commented 1 week ago

Plot is now fixed.

@noobla11 I needed to squeeze the plots even more and had to shorten the titles on the y-axis. The three plots barely fit to laptop screens. The only way how the requested long titles for the y-axes are possible is to kick out another plot. Or we use it like this.

Another way would be that we only show one plot and give the user a select-like control to switch between plots. I would suggest to merge and if you want changes (kick out a graph, add select) open an issue with a priority

noobla11 commented 1 week ago

Yes I see the problem. I think I have to talk with Chris about this or maybe with Felix. Can we also change the size of the plot titles? They are unnecessary huge in my opinion. It does not change the space problem entirely, but it would help?

Yeah I like your suggestion, just merge it for now and I recheck with the others.

noobla11 commented 1 week ago

I checked with Chris, we decided that it's best when it is similar to the Biomasse tab with a drop down. The "Anzahl unterstützter Bienenarten" is the default (maybe called "Unterstützte Bienenarten" in the drop down) and the second choice is then the "Anzahl unterstützter Larven pro Jahr" (maybe called "Bienenartspezifische Information").

mmaelicke commented 1 week ago

That was easy and straightforward. Implemented as requested. The 'Anzahl Insektenarten' already has the correct color.

The colors cannot yet be used everywhere. I'll start to sneak them in from time to time. For the other two plots, the simulations has at first to be reworked, so that it is only calculated for years in which we have data. With that change, I will stratify the plot for 'Bäume' and 'Sträucher' and apply the colors

Thus, I'll merge this soon