hydroframe / ParFlow_PerfTeam

Parflow is an open-source parallel watershed flow model.
http://inside.mines.edu/~rmaxwell/maxwell_software.shtml
Other
0 stars 0 forks source link

Adding Boundary Conditions #17

Closed cathieO closed 5 years ago

cathieO commented 5 years ago

There are some data structures related to boundary conditions that need to be updated. Where is the list that matches the case statements?

Document the process.

Email from Steve Smith I'm a little lost on why this extra Package layer is in there. Reverse engineering it appears to me that the intent was for Package info to be shared across multiple patches...but it doesn't look like input works that way anymore (ever?). The BC input is specified per patch.
The bc_pressure_package is has an input structure for each of the different bc_pressure types. BCPressurePackageNewPublicXtra, does the reading into the Type structures. So you need a new Type9 structure for input data for the new BC type. The input Type are internal to the to the C code (not in .h file). When the BCPressurePackage main method is called it allocates and does some basic setup of the BCPressureType structure the for the BC type. Structure is defined in bc_pressure.h. problem_bc_pressure.[ch] does the full setup of the structures, allocates vectors needed etc. Searching for "Type8" and OverlandBC should hit most of the setup parts. Testing can just be a new problem with the new SeepageFace BC applied? If you know what BC should look like can you just verify pressure is correct along BC?

KoenigKrote commented 5 years ago

Moved procedure to issue #18

KoenigKrote commented 5 years ago

Merged into master Parflow branch https://github.com/parflow/parflow/pull/165