search

hydroframe / SandTank

Sand Tank Outreach Tool
https://hydroframe.github.io/SandTank/
Other
4 stars 5 forks source link

Use "release" Docker build for Docker status badge #12

Closed psavery closed 4 years ago

psavery commented 4 years ago

The Docker build status badge in the README.md is currently pointing to the latest build that was triggered by a PR merge.

However, the Docker builds are no longer triggered by a PR merge, but are triggered by a release being created instead.

In theory, this badge should point to the docker builds created by a release: Docker

But it isn't working, and I think it is because semantic-release is publishing the release from the tag (e. g., v1.0.5). We can point the badge to a specific release, like so:

Docker

But this requires us to change the URL of the badge every time a new release is published.

It would be nice if we had a way to point the Docker status badge to the latest release, but I am not sure if it is possible. Until then, the docker badge on the README.md isn't communicating much - it won't change when a failure occurs.

jourdain commented 4 years ago

You might be able to teach semantic release to update the readme to update the version as well like it does for package.json...

hydroframe-bot commented 3 years ago

:tada: This issue has been resolved in version 1.0.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: