search

hydroframe / SandTank

Sand Tank Outreach Tool
https://hydroframe.github.io/SandTank/
Other
4 stars 5 forks source link

build(deps): bump node-fetch from 2.6.1 to 2.6.7 #59

Closed dependabot[bot] closed 2 days ago

dependabot[bot] commented 2 years ago

Bumps node-fetch from 2.6.1 to 2.6.7.

Release notes

Sourced from node-fetch's releases.

v2.6.7

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

Full Changelog: https://github.com/node-fetch/node-fetch/compare/v2.6.6...v2.6.7

v2.6.6

What's Changed

Full Changelog: https://github.com/node-fetch/node-fetch/compare/v2.6.5...v2.6.6

v2.6.2

fixed main path in package.json

Commits
  • 1ef4b56 backport of #1449 (#1453)
  • 8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310)
  • f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (...
  • b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303)
  • 18193c5 fix v2.6.3 that did not sending query params (#1301)
  • ace7536 fix: properly encode url with unicode characters (#1291)
  • 152214c Fix(package.json): Corrected main file path in package.json (#1274)
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by endless, a new releaser for node-fetch since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/hydroframe/SandTank/network/alerts).

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

buildbot-princeton commented 4 days ago

Can one of the admins verify this patch?

jourdain commented 4 days ago

Who should we add as admin? The current admins don't work on that project anymore. @wh3248?

wh3248 commented 3 days ago

Sebastien,

If you are ok, we can add me as an admin (I tried to add my myself to see if I had rights and I did. So now I’m an admin of the SandTank repo). I am wh3248 (Bill Hasling) and I am an RSE working in Reed Maxwell’s group in Princeton.

  1. We are aware of the repo with the trame version of SandTank. I tried to build Sandtank from the trame repo, but I could not get it to work and it was harder for me to understand than the original SandTank repo. Also, it seems like the education team is used to the original SandTank UI look and feel. Since the trame version is a separate repo we always have the option in the future to figure out how to build the trame version to deploy that version with a different port and URL under *.hydroframe.org.
  2. We have a CI/CD Jenkins job in Princeton that builds a docker image of a test version from a pull request (like the one I just created). This worked and we can deploy SandTank on our poudre.princeton.edu server that runs many of our other Hydrology apps and exposes Sandtank now as “sandtank.hydroframe.org”. It is convenient for us to deploy with a docker image so we don’t collide with versions of EcoSlim, Parflow, NPM and paraview running with other apps on that same server.
  3. I noticed that there are a whole lot of other pull requests outstanding on Sandtank before mine. These are all updates to package.json and package-lock.json that were added by dependabot. Probably I can test and deploy these dependency pull requests before I merge my PR to master. It seems like a good idea and probably unlikely to break anything.

From: Sebastien Jourdain (Kitware) @.> Date: Sunday, June 30, 2024 at 11:44 AM To: hydroframe/SandTank @.> Cc: William M. Hasling @.>, Mention @.> Subject: Re: [hydroframe/SandTank] build(deps): bump node-fetch from 2.6.1 to 2.6.7 (PR #59)

Who should we add as admin? The current admins don't work on that project anymore. @wh3248https://github.com/wh3248?

— Reply to this email directly, view it on GitHubhttps://github.com/hydroframe/SandTank/pull/59#issuecomment-2198602450, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW37GZRELNRVYPT6NLWO3VLZKARVDAVCNFSM6AAAAABKEBMTNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGYYDENBVGA. You are receiving this because you were mentioned.Message ID: @.***>

jourdain commented 3 days ago

Glad to hear you have all control and can do what is needed on those repo.