search

hydroframe / SandTank

Sand Tank Outreach Tool
https://hydroframe.github.io/SandTank/
Other
4 stars 5 forks source link

fix(semantic-release): set git environment variables #8

Closed psavery closed 4 years ago

psavery commented 4 years ago

This will modify the name/email of the committer from semantic-release-bot to hydroframe-bot, according to the documentation.

Additionally, according to the github authentication documentation for semantic-release, the use of GITHUB_TOKEN will not trigger another action,which prevents us from triggering a docker push when a new git tag is pushed by semantic-release. However, it might be talking about the github-provided GITHUB_TOKEN rather than the one we are setting. So I'm not sure if it makes a difference, but we are going to give GH_TOKEN a try.

psavery commented 4 years ago

If the GH_TOKEN doesn't work, perhaps I can trigger a docker tag and a docker push on a release event rather than on a tag event.

psavery commented 4 years ago

The issue of the GH_TOKEN has been resolved by publishing a release via semantic-release, and then triggering the docker push from that, rather than triggering the docker push from a git tag push. This was fixed in #10 and #11.

But it still might be nice to have one bot, the hydroframe-bot, doing the commits. So I am going to merge the first commit so that the hydroframe bot will be the one showing up in the commits (and not the semantic-release-bot).

hydroframe-bot commented 4 years ago

:tada: This PR is included in version 1.0.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: